Re: [PATCH 3/3] push: old receive-pack does not understand --quiet
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:51:58
Clemens Buchacher [off-list ref] writes:
quoted hunk
@@ -114,7 +115,7 @@ static int show_ref(const char *path, const unsigned char *sha1, int flag, void else packet_write(1, "%s %s%c%s%s\n", sha1_to_hex(sha1), path, 0, - " report-status delete-refs side-band-64k", + " report-status delete-refs side-band-64k quiet", prefer_ofs_delta ? " ofs-delta" : ""); sent_capabilities = 1; return 0;@@ -636,6 +637,8 @@ static struct command *read_head_info(void) report_status = 1; if (strstr(refname + reflen + 1, "side-band-64k")) use_sideband = LARGE_PACKET_MAX; + if (strstr(refname + reflen + 1, "quiet")) + quiet = 1;
Side note. We may want to make sure that this is not part of a different token word (if we knew better, we would have written the other side so that we can just test against " quiet ", but that is not possible, sigh...).
quoted hunk
} cmd = xcalloc(1, sizeof(struct command) + len - 80); hashcpy(cmd->old_sha1, old_sha1);@@ -669,7 +672,7 @@ static const char *parse_pack_header(struct pack_header *hdr) static const char *pack_lockfile; -static const char *unpack(int quiet) +static const char *unpack()
I'll amend this as "static const char *unpack(void)" while applying.