Re: [BUG] git push --quiet fails with older versions

On Sat, Sep 03, 2011 at 06:34:13PM +0200, Clemens Buchacher wrote:

Hello Tobias,

On Sat, Sep 03, 2011 at 12:57:23PM +0200, Tobias Ulmer wrote:

quoted

my distro updated git to 1.7.6.1. Now git push --quiet, used in various
scripts, blows up against 1.7.6. I don't know how backwards compatible
git tries to be, but in my opinion that seems like a regression for a
patchlevel release.

Yes, that's a good point. I did not consider that.

quoted

The problem seems to be that the remote git receive-pack does not
understand --quiet. Maybe it is possible to check for the remote version
before sending incompatible commandline parameters?

Indeed, that's what we must do. I am sending three patches in reply
to this email:

[PATCH 1/3] tests for push --quiet
[PATCH 2/3] fix push --quiet via http
[PATCH 3/3] push: old receive-pack does not understand --quiet

The third one fixes this issue on the client side.  It does not
depend on the first two. It applies to v1.7.6.1, maint, and master.
Would be great if you could test.

Hi Clemens,

I've just gotten round to test patch 3/3 and it works perfectly against
1.7.6 as well as 1.7.6.1. It suppresses the output if the remote git
version is 1.7.6.1, like it should.

Thanks for your quick response,
Tobias

Thanks,
Clemens