Thread (7 messages) flat view 7 messages, 5 authors, 2016-06-15

Re: obstack fails to compile on OS X 10.7

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:51:56

David Aguilar [off-list ref] writes:
quoted
-void obstack_free (struct obstack *__obstack, void *__block);
+void obstack_free (struct obstack *obstack, void *block);
Tiny nit: I know it's just a declaration but would it be advisable to
drop the variable names altogether here?
I agree. In general it is easier to read if parameter names to a function
declaration is omitted, especially if it is clear from their types what
they mean [*1*]. And in this case, it is.
Tested-by: David Aguilar <redacted>
Thanks.

[Footnote]

*1* It is Ok to spell them out in a case like this:

    int copy(char *dst, const char *src, size_t);

You do not have to, as "char *" vs "const char *" makes it clear which one
is which.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help