Thread (3 messages) flat view 3 messages, 2 authors, 2016-06-15

Re: [PATCH] rebase -i: clean error message for --continue after failed exec

From: Jeff King <hidden>
Date: 2016-06-15 22:51:54

On Wed, Aug 24, 2011 at 04:20:27PM -0400, Jeff King wrote:
Certainly my only user has ever been "exec make test". But I wonder if
Er, s/user/use.
somebody is crazy enough to auto-generate some content and commit it.
OTOH, shouldn't it then be their responsibility to make the commit?
I.e., I can see at least the potential for mucking with the index, but I
really don't see a reason for _leaving_ the index in a mucked state.
Having just read your followup patch, it looks sane. Exec commands are
free to do whatever they like with the index as long as it is left in a
clean state. That keeps the door open for semi-sane use cases, but will
catch unintended index manipulation.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help