Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH v16 5/7] bisect: introduce --no-checkout support into porcelain.

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:51:44

Jon Seymour [off-list ref] writes:
+bisect_head()
+{
+	if test -f "$GIT_DIR/BISECT_HEAD"; then
+		echo BISECT_HEAD;
+	else
	if test -f ...
        then
        	echo BISECT_HEAD
	else
+	    --no-checkout)
+		mode=--no-checkout;
You seem to be very fond of extraneous semicolons.

Also I very much prefer to write "then" on its own line, indented at the
same level as "if". Consistently doing so will make your if statement a
lot easier to read when some of them need to have multi-line conditionals.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help