Thread (3 messages) flat view 3 messages, 2 authors, 2016-06-15

Re: [PATCH] On Cygwin support both UNIX and DOS style path-names

From: Pascal Obry <hidden>
Date: 2016-06-15 22:51:40

Theo,
quoted
+#define has_dos_drive_prefix(path) (isalpha(*(path))&&  (path)[1] == ':')
+#define is_dir_sep(c) ((c) == '/' || (c) == '\\')
I think that by defining is_dir_sep you enable DOS/Windows style paths
throughout Git, so you might want to check compat/mingw.h for other, related
changes. You will probably at least want the MinGW version of
find_last_dir_sep as well, because the default find_last_dir_sep doesn't use
is_dir_sep.
Thanks for the review/feedback. Will work on that and propose another patch.

Pascal.

-- 

--|------------------------------------------------------
--| Pascal Obry                           Team-Ada Member
--| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE
--|------------------------------------------------------
--|    http://www.obry.net  -  http://v2p.fr.eu.org
--| "The best way to travel is by means of imagination"
--|
--| gpg --keyserver keys.gnupg.net --recv-key F949BD3B
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help