Re: [PATCH/RFC] Pro-Git thanks, Control-flow bug report

@ Jeff King [off-list ref] wrote (2011-07-25 18:25+0200):

Hmm. What's old is new again, I guess. I posted a patch to fix this
almost exactly 3 years ago:

  http://article.gmane.org/gmane.comp.version-control.git/90427

Unfortunately your patch from then seems no longer be sufficient
(i.e., from my point of view, say), since this is also coloured:

  ?0%0[steffen@sherwood git.git]$ ./git -c color.ui=auto -c color.pager=false log

..> It's an ordering problem. [.]
..> However, breaking the dependency chain would require some pretty
..> major surgery, I think. [.]
..> I think the "right" solution would be refactoring the color stuff
..> to make the decision closer to the point of use. [.]

A more elegant solution would be to push the query to color.c to
happen at the time of color use, instead of during the startup
sequence.

Beginners luck.  In the end git(1) will get a visual.c output
manager, and sideband.c rid of that TERM pollution.  :-)

--Steffen
Ciao, sdaoden(*)(gmail.com)
ASCII ribbon campaign           ( ) More nuclear fission plants
  against HTML e-mail            X    can serve more coloured
    and proprietary attachments / \     and sounding animations