Re: [RFC/PATCH] commit: allow partial commits with relative paths

Junio C Hamano [off-list ref] writes:

Michael J Gruber [off-list ref] writes:

quoted

RFC because lack of test, and also because I'm not sure we want this, and
what to do about git add which has the same problem, but would need a
different fix.

The reason you doubt we would want *this* is...?  Also what is the "same
problem"?

Perhaps it would become clearer if you supported *this* with a sample
workflow?

Having said that, I think your change to avoid restricting the overlay to
the current subdirectory makes sense, as long as we allow paths outside
the current subdirectory to be given to the command. I suspect that this
call was relied on an earlier behaviour to error out when paths outside
the current directory were given to the command.

Although I do not know offhand if there are other places in the codepath
with the same issue (i.e. for whatever reason they do not expect to be fed
a relative path, and were relying on the early abort), I think what
your tries to do is taking us in the right direction.