Re: [PATCH v3 2/2] Ensure git ls-tree exits with a non-zero exit code if read_tree_recursive fails.
From: Nguyen Thai Ngoc Duy <hidden>
Date: 2016-06-15 22:51:38
On Sun, Jul 24, 2011 at 9:59 PM, Jon Seymour [off-list ref] wrote:
quoted hunk ↗ jump to hunk
@@ -173,7 +173,6 @@ int cmd_ls_tree(int argc, const char **argv, const char *prefix)tree = parse_tree_indirect(sha1); if (!tree) die("not a tree object"); - read_tree_recursive(tree, "", 0, 0, &pathspec, show_tree, NULL); + return read_tree_recursive(tree, "", 0, 0, &pathspec, show_tree, NULL); - return 0;
Nit picking. Most programs return positive value (usually 1) for error cases here. read_tree_recursive may return -1 (which turns out to be 255). Also removing the last blank line in this function would be nice. -- Duy