Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] stash: Add --include-untracked option to stash and remove all untracked files

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:51:31

David Caldwell [off-list ref] writes:
quoted hunk
@@ -49,6 +57,7 @@ clear_stash () {
 
 create_stash () {
 	stash_msg="$1"
+	untracked="$2"
Hmm...
quoted hunk
@@ -173,7 +213,7 @@ save_stash () {
 	test -f "$GIT_DIR/logs/$ref_stash" ||
 		clear_stash || die "Cannot initialize stash"
 
-	create_stash "$stash_msg"
+	create_stash "$stash_msg" $untracked
Just a minor nit from internal API point of view, I would prefer to see
something like

	create_stash --untracked=all "message"

or even

	create_stash --untracked=all --message="message"

once you start enriching these functions with optional behaviour.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help