[PATCH 2/4] git-instaweb: Use $conf, not $fqgitdir/gitweb/httpd.conf
From: Jakub Narebski <hidden>
Date: 2016-06-15 22:51:31
Subsystem:
the rest · Maintainer:
Linus Torvalds
Don't repeat yourself: use "$conf" instead of its [current] contents, namely "$fqgitdir/gitweb/httpd.conf". Signed-off-by: Jakub Narebski <redacted> --- Straighforward improvement. Note that currently $conf is constant, and doesn't change its value. git-instaweb.sh | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/git-instaweb.sh b/git-instaweb.sh
index 49bab7b..2be22a0 100755
--- a/git-instaweb.sh
+++ b/git-instaweb.sh@@ -103,7 +103,7 @@ start_httpd () { case "$httpd" in *mongoose*|*plackup*) #These servers don't have a daemon mode so we'll have to fork it - $full_httpd "$fqgitdir/gitweb/httpd.conf" & + $full_httpd "$conf" & #Save the pid before doing anything else (we'll print it later) pid=$!
@@ -117,7 +117,7 @@ $pid EOF ;; *) - $full_httpd "$fqgitdir/gitweb/httpd.conf" + $full_httpd "$conf" if test $? != 0; then echo "Could not execute http daemon $httpd." exit 1