Re: [PATCH 12/13] revert: Introduce skip-all to cleanup sequencer data
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:51:30
Ramkumar Ramachandra [off-list ref] writes:
quoted hunk
diff --git a/builtin/revert.c b/builtin/revert.c index 5c0b97e..eb68068 100644 --- a/builtin/revert.c +++ b/builtin/revert.c@@ -46,6 +46,9 @@ enum replay_action { REVERT, CHERRY_PICK }; struct replay_opts { enum replay_action action; + /* --skip-all */ + int skipall_oper;
Yikes what is that "oper" doing there? Don't truncate a word in the middle only to shorten names and make it unclear what you want to say. Is that operand? operation? In this case, I think "int skip_all" is sufficient, and you can lose the comment that adds no extra information.