Re: [PATCH 17/19] transport-helper: export is no longer always the last command

Sverre Rabbelier [off-list ref] writes:

On Thu, Jun 9, 2011 at 09:51, Jonathan Nieder [off-list ref] wrote:

quoted

Yes, but I'm still missing something.  What does the trailing \n ever
have to be written?

"git log -Sdisconnect_helper -- transport-helper.c" doesn't give many
clues.  I imagine it's a way to check whether the child is still alive
and to warn it not to be alarmed when the output end of its input pipe
closes.

Yes, the trailing \n is to signal to the helper that the connection is
about to close, allowing it to do whatever cleanup necessarily. It's
kind of like the "done" command for fast-import.

... which is the kind of clarification I wanted to see as the comment to
document that no_disconnect_req field, whose semantics was unclear even to
two people who are known to know a bit about git and had to ask you to
clarify.