Re: [PATCH v3 2/2] submodule update: continue when a checkout fails

Fredrik Gustafsson [off-list ref] writes:

+				*)
+					err="${err} \"Failed to $action in submodule path '$path'\""
...
+					err="${err} \"Failed to recurse into submodule path '$path'\""
+					continue
+				else
+					die_with_status $res "Failed to recurse into submodule path '$path'"
+				fi
+			fi
 		fi
 	done
+
+	if test -n "$err"
+	then
+		OIFS=$IFS
+		IFS=';'
+		for e in $err

Hmm, I do not see anybody concatenating things with semicolons in between...
Am I reading a right patch?

Also I am puzzled what the double-quotes around each error message are
doing. Are they meant to be shown to the end user?

+		do
+			echo $e

Should this go to the standard error output?

+		done
+		IFS=$OIFS
+		die

Do we want to give an extra empty line here with "die"?