Re: [PATCHv3 1/2] Add a remote helper to interact with mediawiki, pull & clone handled

2011/6/9 Sverre Rabbelier [off-list ref]:

Heya,

On Thu, Jun 9, 2011 at 15:15, Jeremie Nikaes
[off-list ref] wrote:

quoted

+sub mw_capabilities {
+       print STDOUT "push\n";

quoted

+sub mw_push {
+       print STDERR "Push not yet implemented\n";
+}

If it's not supported then you shouldn't advertise it above. Is there
any particular reason you implemented it this way? E.g., did you
encounter a breakage in remote-helpers if push is not implemented?

Well, if you dont give the capability to push, you get the following message

error: failed to push some refs to 'mediawiki::http://mediawikiurl'

Which is less explicit than 'Push not yet implemented'.


Regards,
-- 
Jérémie Nikaes