Thread (3 messages) flat view 3 messages, 2 authors, 2016-06-15

Re: [PATCH] Add a remote helper to interact with mediawiki, pull & clone handled

From: Jérémie NIKAES <hidden>
Date: 2016-06-15 22:51:25

use warnings; ?
Thanks, added this, showed some uses of undefined variables now fixed.
Will figure in the next patch.
quoted
+use Switch;
Ugh -- no.  This is terrible.  Look at this:

[~]% corelist Switch
Switch was first released with perl v5.7.3 and removed from v5.13.1

Since you do not specify a minimum perl version you might be alright,
but for those people on 5.14 -- they won't have this module, for good
reason.  You can, if you wanted use "given/when" as alternate
constructs to this.
Yes, as I said to Junio Hamano in my previous mail, that's a mistake
from my part, we don't use switch anymore. Sorry about that
quoted
+use MediaWiki::API;
+use Storable qw(freeze thaw);
This might have problems transcending storable formats made on a 32bit
machine, and then trying to unpack them again on 64bit.  Do you really
need the need for these storable items to be encoded as binary?
Hmmm that is a leftover use from the script of Jeff King that we used.
We don't use this anymore, so that should not be a problem.

Thanks for your advices !

--
Jérémie Nikaes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help