[RFC PATCH 1/2] submodule: move update configuration variable further up
From: Heiko Voigt <hidden>
Date: 2016-06-15 22:51:25
Subsystem:
the rest · Maintainer:
Linus Torvalds
Lets always initialize the 'update_module' variable with the final value. This way we allow code which wants to check this configuration early to do so right in the beginning of cmd_update(). --- git-submodule.sh | 13 +++++++------ 1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/git-submodule.sh b/git-submodule.sh
index d189a24..70dfc7b 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh@@ -454,7 +454,13 @@ cmd_update() fi name=$(module_name "$path") || exit url=$(git config submodule."$name".url) - update_module=$(git config submodule."$name".update) + if ! test -z "$update" + then + update_module=$update + else + update_module=$(git config submodule."$name".update) + fi + if test -z "$url" then # Only mention uninitialized submodules when its
@@ -476,11 +482,6 @@ cmd_update() die "Unable to find current revision in submodule path '$path'" fi - if ! test -z "$update" - then - update_module=$update - fi - if test "$subsha1" != "$sha1" then subforce=$force
--
1.7.5.1.219.g4c6b2