[PATCH 0/3] gitweb: Improving blame_incremental.js
From: Jakub Narebski <hidden>
Date: 2016-06-15 22:51:20
Two first patches remove unnecessary code from JavaScript-side of
blame_incremental code. Namely JavaScript is single-threaded (events
wait for interpreter), so there is no need for code that tried to
handle re-entrancy (concurent access) to blame_incremental.js
functions.
So those two are pure simplification.
The third (last) patch replaces setInterval (where events might
accumulate if browser is very busy) to recommended re-enabled
setTimeout. Thanks to this change we are now able to detect if timer
is not necessary, and in that case disable it. This means extra code
checking if there is timer to disable (perhaps unnecessary).
This one adds more code than it removes, and could be split into two
patches: one simply moving from setInterval to setTimer, second adding
those new features.
P.S. Does anybody knows how to test JavaScript part of gitweb code
_from commandline_ generating TAP-compatibile output to stdout?
Shortlog:
~~~~~~~~~
Jakub Narebski (3):
gitweb.js: No need for inProgress in blame_incremental.js
gitweb.js: No need for loop in blame_incremental's handleResponse()
gitweb.js: use setTimeout rather than setInterval in
blame_incremental.js
Diffstat:
~~~~~~~~~
gitweb/static/js/blame_incremental.js | 79 +++++++++++++++++---------------
1 files changed, 42 insertions(+), 37 deletions(-)
--
1.7.5