Re: [PATCH 1/2] Add additional build options for Interix, and remove obsolete ones.
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:51:19
mduft@gentoo.org writes:
Interix versions older than 6.0 (so 3.5 and 5.2) both lack struct sockaddr_storage and the FNM_CASEFOLD GNU extension, so disable them both. The removed options are obsolete, because interix support now depends on libsuacomp.
and linkage with -lsuacomp happens automatically without any change in the Makefile for anybody? Just asking, as I do not have an access to (nor any particular desire to get an access to) an Interix to figure it out myself, and the only think I care about in this patch is if it helps only your installation or it will help everybody who has Interix but not necessarily with the same set of additional configuration as you have.
quoted hunk
Signed-off-by: Markus Duft <redacted> --- Makefile | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-)diff --git a/Makefile b/Makefile index db72c45..c47cd4e 100644 --- a/Makefile +++ b/Makefile@@ -1113,8 +1113,6 @@ endif X = .exe endif ifeq ($(uname_S),Interix) - NO_SYS_POLL_H = YesPlease - NO_INTTYPES_H = YesPlease NO_INITGROUPS = YesPlease NO_IPV6 = YesPlease NO_MEMMEM = YesPlease@@ -1125,10 +1123,14 @@ ifeq ($(uname_S),Interix) ifeq ($(uname_R),3.5) NO_INET_NTOP = YesPlease NO_INET_PTON = YesPlease + NO_SOCKADDR_STORAGE = YesPlease + NO_FNMATCH_CASEFOLD = YesPlease endif ifeq ($(uname_R),5.2) NO_INET_NTOP = YesPlease NO_INET_PTON = YesPlease + NO_SOCKADDR_STORAGE = YesPlease + NO_FNMATCH_CASEFOLD = YesPlease endif endif ifneq (,$(findstring MINGW,$(uname_S)))