Thread (2 messages) flat view 2 messages, 1 author, 2016-06-15
DORMANTno replies

[PATCH] Simple dead assignment

From: Chris Wilson <hidden>
Date: 2016-06-15 22:51:18
Subsystem: the rest · Maintainer: Linus Torvalds

On Tue, May 24, 2011 at 05:07:58PM -0400, Chris Wilson wrote:
Sentry picked up this dead assignment commited yesterday in ba67aaf.
I've provided a patch to remove it. It might also be a good idea to
ask the author if that value was supposed to be used for something
in particular before pulling it out.
Oops, I see others putting the patches inline. Here you go.

Chris

-- 
Chris Wilson
http://vigilantsw.com/
Vigilant Software, LLC
diff --git a/sh-i18n--envsubst.c b/sh-i18n--envsubst.c
index 7125093..5829463 100644
--- a/sh-i18n--envsubst.c
+++ b/sh-i18n--envsubst.c
@@ -67,9 +67,6 @@ static void subst_from_stdin (void);
 int
 main (int argc, char *argv[])
 {
-  /* Default values for command line options.  */
-  unsigned short int show_variables = 0;
-
   switch (argc)
 	{
 	case 1:
@@ -88,7 +85,6 @@ main (int argc, char *argv[])
 	  /* git sh-i18n--envsubst --variables '$foo and $bar' */
 	  if (strcmp(argv[1], "--variables"))
 		error ("first argument must be --variables when two are given");
-	  show_variables = 1;
       print_variables (argv[2]);
 	  break;
 	default:
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help