Re: [PATCH v2 06/11] streaming: a new API to read from the object store

René Scharfe [off-list ref] writes:

quoted

+#define read_method_decl(name) \
+	ssize_t read_istream_ ##name \
+	(struct git_istream *st, char *buf, size_t sz)

It would be nice if those macros could be got rid of once the interface
stabilizes.

Probably, but not while it is still in flux in 'pu'. I already had to
tweak something to support my unpublished series I was working on today.

quoted

+struct git_istream {
+	enum input_source source;

source seems to be write-only.

Yes, I had this initially but later ended up with a design that makes
everything go through vtbl, so this is only useful for debugging and can
be removed.

Thanks.