Re: [PATCHv2] add Android support
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:51:16
Rafael Gieschke [off-list ref] writes:
quoted
(3) Add uname_S = Android (Makefile). The first two would become much easier to justify if presented that way. At least you won't hear from anybody "we don't want that much code to not to run git on a phone!", as it is not entirely implausible to imagine environments without support for one or both of these two facilities.So, you would prefer to leave out ANDROID and use something like "ifeq ($(uname_S),Android)", so you will have to compile using make uname_S=Android? I would be fine with that, too. But I would also be fine with having to specify the build options on the command line or using a config.mak if you want to keep Android out of the Makefile.
Ignore differences s/Android/ANDROID/; I just typed differently without even noticing I was doing so (the same for GECOS-PWENT but if you liked my name better that is fine by me as well). The point is that I didn't mean to suggest changing names of symbols you used.