Re: [PATCH 20/48] i18n: git-submodule die + eval_gettext messages

On Thu, May 12, 2011 at 10:08, Johannes Sixt [off-list ref] wrote:

Am 5/8/2011 14:20, schrieb Ævar Arnfjörð Bjarmason:

quoted

-             say "Submodule '$name' ($url) registered for path '$path'"
+             say "$(eval_gettext "Submodule '\$name' (\$url) registered for path '\$path'")"

On Windows, we have a problem with messages like this (and many others)
that reference $path. eval_gettext has to export 'path', but on Windows
environment variables are case-insensitive. In the substitution, this
happens to pick the value of 'PATH' rather than of 'path'... Can you do
something about this?

Of course, the problem is not limited to 'path' at all, but it is a
prominent example discovered by the test suite.

I didn't know Windows had that limitation. We can easily work around
it by just renaming $path to something else (e.g. $filepath).

Since we do:

    export PATH $(git sh-i18n--envsubst --variables "$1");

I assume this problem only occurs with variables that match
/^path$/i. Or are there other problems on Windows?

I don't have a Windows machine, and I'm not about to buy a license. So
getting the output of the failing test suite would be very useful if
this happens for variables other than $path.

If it's only $path I'll just change it to something else and include
that change in v2 of the series.