Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] Add default merge options for all branches

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:51:08

Michael Grubb [off-list ref] writes:
The approach taken is to make note of whether a branch specific
mergeoptions key has been seen and only apply the global value if it
hasn't. An alternative method would be to keep the
branch.<branch>.mergeoptions semantics, but assign a special value for
<branch> to be the global default.
Both my gut feeling and design taste tell me that "branch.*.mergeoptions"
(using literal '*' for match-all for now) would be a lot more appropriate
here.  We could extend the '*' part later to take globs.

The resulting part of the configuration file would look like this:

	[branch "*"]
        	mergeoptions = ...

and later we would end up supporting other kinds of defaults, like:

	[branch "ko/*"]
        	remote = korg
	[branch "github/*"]
        	remote = github
                mergeoptions = ...

I didn't read the patch carefully but there seems to be many instances of
the same "excess whitespace" pattern you should be able to avoid easily to
match the style by looking at the surrounding code.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help