Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH v2] t/README: unify documentation of test function args

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:51:06

Drew Northup [off-list ref] writes:
On Tue, 2011-04-26 at 12:33 +0200, Mathias Lafeldt wrote:
quoted
@@ -389,7 +389,7 @@ library for your script to use.
 	    'git-write-tree should be able to write an empty tree.' \
 	    'tree=$(git-write-tree)'
 
-   If you supply three parameters the first will be taken to be a
+   If you supply three parameters, the first will be taken to be a
    prerequisite, see the test_set_prereq and test_have_prereq
    documentation below:
As "If you supply three parameters" is not an introductory clause to a
larger complete thought in the following few words, the additional comma
is unnecessary.
Makes sense.

On the other hand, "see the ... below" is a separate sentence, and it
deserves to have something stronger than a comma in front of it.  I've
queued with a minor fixup.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help