Thread (7 messages) flat view 7 messages, 3 authors, 2016-06-15
DORMANTno replies

[PATCH v2 0/2] Re: run-command: write full error message in die_child

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:51:04

Johannes Sixt wrote:
Unfortunately, on Windows, the bash spawnd by git converts LF to CRLF...
[...]
... therefore, we fail here. Can we have this squashed in, because 'cat'
leaves LFs alone?
Thanks for catching this...

[...]
I did not check whether
SANITY is really needed; I trust you did.
... and this.  No, SANITY is not needed.

Here's a reroll, on top of v1.7.5-rc3~2 (Revert "run-command: prettify
-D_FORTIFY_SOURCE workaround", 2011-04-18).  It even applies on maint
this way (not that anyone would need that :)).

Jonathan Nieder (2):
  tests: check error message from run_command
  run-command: handle short writes and EINTR in die_child

 run-command.c          |   15 +++++++++------
 t/t0061-run-command.sh |   23 +++++++++++++++++++++++
 test-run-command.c     |    2 ++
 3 files changed, 34 insertions(+), 6 deletions(-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help