Re: [PATCH] format-patch: document --quiet option
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:51:02
Carlos Martín Nieto [off-list ref] writes:
Signed-off-by: Carlos Martín Nieto <redacted> --- I guess this should be squashed into the previous one. I forgot it wasn't documented, partly because reading the commit log for ec2956df59 (Nate Case, format-patch: Respect --quiet option) says the man page suggests this should work.
I don't think the manual page ever meant to say anything like that. It used to include generic "diff" options from manual pages from diff-tree and friends, but the "output" the description refers to is the diff output and later dropped by protecting the description in diff-options.txt with "ifndef::git-format-patch[]" in the Documentation/ sources.
quoted hunk
@@ -192,6 +192,9 @@ will want to ensure that threading is disabled for `git send-email`. filenames, use specified suffix. A common alternative is `--suffix=.txt`. Leaving this empty will remove the `.patch` suffix. + +--quiet:: + Do not print the patch names to standard output.
I see "filenames" in the context and that is "generated filenames". Be consistent and don't introduce an undefined term "patch names" here; it will lead to confusing readers to think as if the "generated filenames" and "patch names" are different things.