Re: [PATCH/RFC 1/7] i18n: mark init-db messages for translation

On Tue, Apr 12, 2011 at 09:15, Junio C Hamano [off-list ref] wrote:

Junio C Hamano [off-list ref] writes:

quoted

Ævar Arnfjörð Bjarmason [off-list ref] writes:

quoted

     fp = fopen(git_link, "w");
     if (!fp)
-            die("Could not create git link %s", git_link);
-    fprintf(fp, "gitdir: %s\n", git_dir);
+            die(_("Could not create git link %s"), git_link);
+    fprintf(fp, _("gitdir: %s\n"), git_dir);
     fclose(fp);
...

I don't think this is correct.  The file "git_link" refers to .git that is
not a directory but is a regular file whose contents is "gitdir: $path"
and that should _never_ be localized, so the patch to die() message is Ok,
but the string given to fprintf(fp, ...) is _not_.

See read_gitfile_gently() in setup.c; that is the reader of the
information contained in this file.

Ah, thanks. Missed that. I'd have spotted it if I dug down instead of sending.

I'll re-send one without the translation for this plumbing message.