Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH] pathspec: rename per-item field has_wildcard to use_wildcard

From: Nguyen Thai Ngoc Duy <hidden>
Date: 2016-06-15 22:50:59

2011/4/6 Junio C Hamano [off-list ref]:
 * I was looking at the codepaths that would need to be touched in order
  to properly support the "magic pathspec" we have been discussing, and
  am leaning to conclude that all the users of get_pathspec() need to be
  rewritten to throw the remainder of argv[] at a function that fills a
  struct pathspec (in other words, a combination of get_pathspec() and
  init_pathspec()).  Michael's "alternative approach to grep --full-tree"
  was operating at the get_pathspec() level, but that function is an
  interface to return an array of plain-vanilla strings only, and there
  is no place to hook richer per-item information on the elements.  We
  would need "struct pathspec" in the function where we parse the argv[]
  and combine its elements with prefix.
I have started working on the conversion, but it may take a while
because in many places pathspec is still assumed a prefix (and handled
separately, which is not good for negative pathspec). Fundamental
support for magic pathspec and "top dir" notation probably do not need
get_pathspec() converted to struct pathspec.
-- 
Duy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help