Thread (39 messages) flat view 39 messages, 3 authors, 2016-06-15
STALE3751d

[PATCH 2/4] finish_async: be quiet when waiting for async process

From: Jeff King <hidden>
Date: 2016-06-15 22:50:57
Subsystem: the rest · Maintainer: Linus Torvalds

When we ask to finish_async, we should be quiet about things
like signal death in the async process, for two reasons:

  1. This better matches what happens on the Windows side,
     where threads are used (and what will eventually happen
     when pthreads are used on unix).

  2. We pass along the error code to the caller, who needs
     to check and produce an error message anyway for the
     case of a non-zero exit code.

Signed-off-by: Jeff King <redacted>
---
 run-command.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/run-command.c b/run-command.c
index 0d5626a..258c880 100644
--- a/run-command.c
+++ b/run-command.c
@@ -427,7 +427,7 @@ error:
 int finish_async(struct async *async)
 {
 #ifndef WIN32
-	int ret = wait_or_whine(async->pid, "child process", 0);
+	int ret = wait_or_whine(async->pid, "child process", 1);
 #else
 	DWORD ret = 0;
 	if (WaitForSingleObject(async->tid, INFINITE) != WAIT_OBJECT_0)
-- 
1.7.4.13.g8566c
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help