Re: [RFC/PATCH 3/3] builtin/show.c: do not prune by pathspec

Nguyen Thai Ngoc Duy venit, vidit, dixit 31.03.2011 15:35:

On Thu, Mar 31, 2011 at 8:26 PM, Michael J Gruber
[off-list ref] wrote:

quoted

quoted

Tests please?

Heck, we don't have any to begin with, and this is marked RFC. Given our
usual reluctance to change even undocumented behavior I'm not going to
bother with tests for an RFC.

Ugh.. I missed the "RFC" part on the subject. Sorry.

quoted

quoted

quoted

As an intended side effect, users mistaking "git show commit -- path"
for "git show commit:path" are automatically reminded that they asked
git to show a commit, not a blob.

Nor a tree. I don't really see how "git show commit:path" and "git how
commit -- path" are relevant for it to be mentioned here.

"git show commit:path" is relevant because that is what the OP was
trying to do, and "git show commit:path" is relevant because that is
what the OP tried and confused him because there was no output at all.
Not to mention that this is the command this patch is about.

Thanks. I see I also missed the original thread somewhere. Someone
needs a sleep, me thinks :)

I'm trying with the coffee that I had suggested (seems to be working),
but I guess that decision (between coffee and sleep) depends on the
timezone also :)

Michael