Re: [RFC 1/3] Alternates API: Untangle the interface
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:50:56
Michael Witten [off-list ref] writes:
quoted hunk
diff --git a/transport.c b/transport.c index a02f79a..c61723f 100644 --- a/transport.c +++ b/transport.c@@ -1190,14 +1190,13 @@ literal_copy: return xstrdup(url); } -int refs_from_alternate_cb(struct alternate_object_database *e, void *cb) +int refs_from_alternate_cb(struct alternate_object_database *e, alternate_ref_fn ref_fn) {
Adding an extra "fn" is Ok, but I'd rather not to see removal of generic callback data pointer if the _only_ reason you are doing so is "currently nobody uses it". Besides, I see "a function pointer and a data pointer cannot be held in a single variable" as an academic mental mastu^wexercise that is useless in real life. Are there real platforms that matter where (void *) cannot hold a pointer to a function?