Re: [PATCH] Remove "bashism" from contrib/thunderbird-patch-inline/appp.sh

Maxin john wrote:

Remove "bashism" and minor corrections for
contrib/thunderbird-patch-inline/appp.sh

Signed-off-by: Maxin B. John <redacted>

This is wrong.

You are replacing bash with sh:

-#!/bin/bash
+#!/bin/sh

but the script still uses bash-specific syntax (aka. bashishms):

+
 PATCH=$(zenity --file-selection)

 if [ "$?" != "0" ] ; then

So with your change the script won't be able to run on systems which
don't have bash as /bin/sh