Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCHv3 0/5]rev-list and friends: --min-parents, --max-parents

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:50:51

Jeff King [off-list ref] writes:
quoted
Junio, please let me/us know whether sending an amended series in this way
(which I've seen before) is actually convenient for you or not. !squash
commits require a message edit, for example. OTOH, I don't know any (other?)
good inter diff solution.
As a reviewer, I find it is usually most convenient to just have the
submitter do the squash, and then write below the "---" (or in a cover
letter like this) a brief explanation of the differences.

Yeah, I end up reading the whole patch again, including bits I already
read, but that is probably a good thing. A good patch is hopefully not
too long, and it is easier (to me, anyway) to review it as a whole and
not as an interdiff.
Yes.  And that would also make it easier for people who didn't read the
earlier round to double check.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help