Re: [PATCH 1/2] diff/status: refactor opportunistic index update

Piotr Krukowiecki [off-list ref] writes:

On Mon, Mar 21, 2011 at 6:16 PM, Junio C Hamano [off-list ref] wrote:

quoted

+void update_index_if_able(struct index_state *istate, struct lock_file *lockfile)
+{
+       if (istate->cache_changed) &&
+           !write_index(istate, lockfile->fd))

Mismatched parenthesis? Should be sth like

+       if (istate->cache_changed &&
+           !write_index(istate, lockfile->fd))

Yeah, "rebase -i" gotcha.  Applying [2/2] should get rid of it anyway.