Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCHv2 2/3] revision.c: introduce --min-parents and --max-parents

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:50:50

Michael J Gruber [off-list ref] writes:
Implementation note:

We compute the number of parents only when we limit by that, so there
is no performance impact when there are no limiters.
Only about 16% of the commits in git.git (and 7% in the kernel) are two
parent merges and the rest are mostly single strand of pearls, so even the
cost of counting all the parents in a loop that does not exit early when
it reaches max-parents limit should be negligible, and checking against
max-parents in each iteration would probably costs even more.

So I think this is a good to go.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help