Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 1/3] make_absolute_path: return the input path if it points to our buffer

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:50:47

Carlos Martín Nieto [off-list ref] writes:
quoted hunk
Some codepaths call make_absolute_path with its own return value as
input. In such a cases, return the path immediately.

This fixes a valgrind-discovered error, whereby we tried to copy a
string onto itself.

Signed-off-by: Carlos Martín Nieto <redacted>
---
 abspath.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/abspath.c b/abspath.c
index 91ca00f..ff14068 100644
--- a/abspath.c
+++ b/abspath.c
@@ -24,6 +24,10 @@ const char *make_absolute_path(const char *path)
 	char *last_elem = NULL;
 	struct stat st;
 
+	/* We've already done it */
+	if (path == buf || path == next_buf)
+		return path;
+
I like this, as it is very obvious what we are checking here.  Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help