Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 2-3/3] Name make_*_path functions more accurately

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:50:47

Carlos Martín Nieto [off-list ref] writes:
On Wed, 2011-03-16 at 17:59 +0100, Michael J Gruber wrote:
quoted
Why remove the check? Again, this is not just renaming.
 Semantics change. Same as above. The one below (snipped) is the same.
quoted
quoted
[...]
I think you should strictly separate the renaming issue from other
patches (and describe/motivate the latter). It's fine to have a large
patch with mechanical changes (renaming) if you stick to just those.
 Unfortunately I introduced some modifications trying to reduce the
number of times we call make_absolute_path/real_path and they snuck in.
Michael, thanks for helping with good eyes.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help