Thread (18 messages) 18 messages, 5 authors, 2016-06-15

Re: [PATCH nd/struct-pathspec] declare 1-bit bitfields to be unsigned

flat view

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:50:47

Jonathan Nieder [off-list ref] writes:
As "gcc -pedantic" notices, a two's complement 1-bit signed integer
cannot represent the value '1'.
Thanks; this is one of the things I try to be reasonably careful about
when I eyeball patches, but apparently I didn't spot it.

Perhaps I should start compiling with -Woverflow.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help