Re: [PATCH] commit: error out for missing commit message template

Jonathan Nieder [off-list ref] writes:

quoted

--- a/builtin/commit.c
+++ b/builtin/commit.c

@@ -725,15 +725,15 @@ static int prepare_to_commit(const char *index_file, const char *prefix,

[...]

quoted

-				"%s"
-				"# Author:    %s\n",
+				_("%s"
+				"# Author:    %s\n"),

The above change causes the commit message template to be nonempty,
excluding comments, so bare "git commit" succeeds, exposing this
longstanding bug.

Thanks; using "#" at the beginning of poison message sometimes has its
uses ;-)

Will queue.