Re: [PATCH 2/8] strbuf: add strbuf_addv
From: Jeff King <hidden>
Date: 2016-06-15 22:50:39
On Thu, Feb 24, 2011 at 04:05:13PM +0100, Christian Couder wrote:
quoted
+ len = vsnprintf(sb->buf + sb->len, sb->alloc - sb->len, fmt, cp); + va_end(cp); if (len < 0) - die("your vsnprintf is broken"); + die("BUG: your vsnprintf is broken (returned -1)");Minor nit: why not: + die("BUG: your vsnprintf is broken (returned %d)", len);
No reason. I'll switch to yours in my re-roll. -Peff