Re: [PATCH v2 5/8] git-p4: reinterpret confusing p4 message
From: Tor Arvid Lund <hidden>
Date: 2016-06-15 22:50:38
On Sat, Feb 19, 2011 at 2:17 PM, Pete Wyckoff [off-list ref] wrote:
Error output will look like this: glom$ git p4 clone //deopt Importing from //deopt into . Reinitialized existing Git repository in /tmp/x/.git/ Doing initial import of //deopt from revision #head into refs/remotes/p4/master p4 returned an error: //deopt/... - must refer to client glom. This particular p4 error is misleading. Perhaps the depot path was misspelled. Depot path: //deopt Signed-off-by: Pete Wyckoff <redacted>
Acked-by: Tor Arvid Lund <redacted> :-)
quoted hunk ↗ jump to hunk
--- contrib/fast-import/git-p4 | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4 index db19b17..6b847c4 100755 --- a/contrib/fast-import/git-p4 +++ b/contrib/fast-import/git-p4@@ -1445,6 +1445,10 @@ class P4Sync(Command):if 'code' in info and info['code'] == 'error': sys.stderr.write("p4 returned an error: %s\n" % info['data']) + if info['data'].find("must refer to client") >= 0: + sys.stderr.write("This particular p4 error is misleading.\n") + sys.stderr.write("Perhaps the depot path was misspelled.\n"); + sys.stderr.write("Depot path: %s\n" % " ".join(self.depotPaths)) sys.exit(1) if 'p4ExitCode' in info: sys.stderr.write("p4 exitcode: %s\n" % info['p4ExitCode']) -- 1.7.4.1