Re: [PATCH] smart-http: Don't use Expect: 100-Continue
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:50:34
Subsystem:
the rest · Maintainer:
Linus Torvalds
Possibly related (same subject, not in this thread)
- 2016-06-15 · [PATCH] smart-http: Don't use Expect: 100-Continue · Shawn O. Pearce <hidden>
- 2016-06-15 · Re: [PATCH] smart-http: Don't use Expect: 100-Continue · Junio C Hamano <hidden>
"Shawn O. Pearce" [off-list ref] writes:
quoted hunk
diff --git a/remote-curl.c b/remote-curl.c index 04d4813..3d82dc2 100644 --- a/remote-curl.c +++ b/remote-curl.c@@ -356,14 +356,59 @@ static size_t rpc_in(const void *ptr, size_t eltsize,... +static int probe_rpc(struct rpc_state *rpc) +{ +... + curl_easy_setopt(slot->curl, CURLOPT_WRITEFUNCTION, fwrite_buffer); + curl_easy_setopt(slot->curl, CURLOPT_FILE, buf); + + err = run_slot(slot); + + curl_slist_free_all(headers); + strbuf_release(&buf); + return err; +}
Hmm, I am getting
remote-curl.c:403: error: call to '_curl_easy_setopt_err_cb_data' declared
with attribute warning: curl_easy_setopt expects a private data pointer as
argument for this option
Shouldn't the above be giving a pointer to buf anyway?
remote-curl.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/remote-curl.c b/remote-curl.c
index 297ecf7..256326a 100644
--- a/remote-curl.c
+++ b/remote-curl.c@@ -400,7 +400,7 @@ static int probe_rpc(struct rpc_state *rpc) curl_easy_setopt(slot->curl, CURLOPT_POSTFIELDSIZE, 4); curl_easy_setopt(slot->curl, CURLOPT_HTTPHEADER, headers); curl_easy_setopt(slot->curl, CURLOPT_WRITEFUNCTION, fwrite_buffer); - curl_easy_setopt(slot->curl, CURLOPT_FILE, buf); + curl_easy_setopt(slot->curl, CURLOPT_FILE, &buf); err = run_slot(slot);