Re: [PATCH] correct type of EMPTY_TREE_SHA1_BIN

Jonathan Nieder [off-list ref] writes:

Junio C Hamano wrote:

quoted

quoted

--- a/cache-tree.c
+++ b/cache-tree.c

@@ -621,9 +621,18 @@ static void prime_cache_tree_rec(struct cache_tree *it, struct tree *tree)
 			struct tree *subtree = lookup_tree(entry.sha1);
 			if (!subtree->object.parsed)
 				parse_tree(subtree);
+			if (!hashcmp(entry.sha1, (unsigned char *)EMPTY_TREE_SHA1_BIN)) {
+				warning("empty tree detected! Will be removed in new commits");
+				cnt = -1;
+				break;
+			}

You shouldn't need the cast (if you did, then hashcmp() macro should be
fixed so that you don't need to).

Isn't this a bug in the definition of EMPTY_TREE_SHA1_BIN rather than
the signature of hashcmp?

Yeah, you are right.