Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH v3 1/3] Add setup_merge_commit function to merge/builtin.c.

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:50:32

Jared Hance [off-list ref] writes:
Subject: Re: [PATCH v3 1/3] Add setup_merge_commit function to merge/builtin.c.
Please spell the name of the file you are touching correctly ;-).

	Subject: builtin/merge.c: Add setup_merge_commit function
Adds a new function that will be used in a later patch as well as the
current code to reduce redundancy.
Redandunt.  If you say "add", we know the function is "new" ;-)

State what that function does instead of a vague "reduce redundancy",
perhaps like...

	Refactor the loop to parse list of commits given from the command
        line into a separate helper function.

The patch itself looks good.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help