Re: [PATCH] git-p4: correct indenting and formatting

Junio C Hamano [off-list ref] writes:

Andrew Garber [off-list ref] writes:

quoted

- replace tabs with appropriate number of spaces
- minor tweaks to code formatting
---
 contrib/fast-import/git-p4 |   71 +++++++++++++++++++++-----------------------
 1 files changed, 34 insertions(+), 37 deletions(-)

Sorry, but in git codebase, tabs are 8-place indent by definition, and I
don't see much merit in this patch, other than being religious about
somebody else's coding style, which would matter only if we are trying to
get this included in "batteries included" set shipped with Python
distribution, perhaps.

A downside is that this patch will make life harder for people with
private patches to git-p4 that they haven't shared with us.

Sorry, I obviously was not paying attention to the patch itself.

The file already mostly follows the Python convention to use only SP and
you are fixing some oddballs that have HT instead of typing 8 SPs out to
make things consistent.

I don't see any problem with that kind of change.

Will queue on a separate branch for you, expecting that you are doing this
in preparation for a new feature or a bugfix to the script.

Thanks.