Thread (3 messages) flat view 3 messages, 2 authors, 2016-06-15

Re: [PATCH] svndump.c: Fix a printf format compiler warning

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:50:22

Ramsay Jones wrote:
quoted hunk ↗ jump to hunk
--- a/vcs-svn/svndump.c
+++ b/vcs-svn/svndump.c
@@ -211,7 +211,7 @@ void svndump_read(const char *url)
 		if (key == keys.svn_fs_dump_format_version) {
 			dump_ctx.version = atoi(val);
 			if (dump_ctx.version > 2)
-				die("expected svn dump format version <= 2, found %d",
+				die("expected svn dump format version <= 2, found %"PRIu32,
 				    dump_ctx.version);
Acked-by: Jonathan Nieder <redacted>

I think we should just use "int", but that is a wider sweeping change
for another time.  Thanks.

Does gcc or sparse provide a warning that could have caught this
mistake?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help