Re: [PATCH] Fix expected values of setup tests on Windows

Johannes Sixt [off-list ref] writes:

On Freitag, 31. Dezember 2010, Jonathan Nieder wrote:

quoted

Johannes Sixt wrote:

quoted

On Freitag, 31. Dezember 2010, Nguyen Thai Ngoc Duy wrote:

quoted

in your patch does not. Does bash auto convert value in
TRASH_DIRECTORY="$TE..." line?

No. When this line is executed:

TEST_DIRECTORY=$(pwd)

$(pwd) still has its default behavior to return the POSIX style path. pwd
is redefined to pwd -W only later.

Would it make sense to change it to

 TEST_DIRECTORY=$PWD

for clarity and robustness against code movement, then?

Yes, that would make sense.

It will be very much appreciated to add a few sentences to clarify this to
"Do's and don'ts" section of t/README if you are re-rolling this.  Thanks.