Re: [PATCH] completion: add missing configuration variables

On Thu, Dec 16, 2010 at 08:14:54AM +0100, Martin von Zweigbergk wrote:

quoted

On Wed, Dec 15, 2010 at 08:44:45PM +0100, Martin von Zweigbergk wrote:

quoted

On Wed, 15 Dec 2010, Jeff King wrote:

quoted

As an aside, I would think "--unset" should actually choose from the set
of configured variables for completion (i.e., "git config --list | cut
-d= -f1"). But that would obviously be a separate patch.

Good point. I'll put it on my todo.

It already works that way since 0065236 (bash completion: complete
variable names for "git config" with options, 2009-05-08).

Nice. Thanks. Removed from my todo :-). Then I don't see any reason at
all to keep color.grep.external and add.ignore-errors.

Agreed. Thanks.

-Peff