Re: [PATCH 3/3] get_sha1: support ref^{/regex} syntax
From: Nguyen Thai Ngoc Duy <hidden>
Date: 2016-06-15 22:50:15
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCH 3/3] get_sha1: support ref^{/regex} syntax · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH 3/3] get_sha1: support ref^{/regex} syntax · Nguyen Thai Ngoc Duy <hidden>
- 2016-06-15 · [PATCH 3/3] get_sha1: support ref^{/regex} syntax · Nguyễn Thái Ngọc Duy <hidden>
- 2016-06-15 · Re: [PATCH 3/3] get_sha1: support ref^{/regex} syntax · Nguyen Thai Ngoc Duy <hidden>
- 2016-06-15 · Re: [PATCH 3/3] get_sha1: support ref^{/regex} syntax · Jonathan Nieder <hidden>
On Wed, Dec 15, 2010 at 9:56 AM, Junio C Hamano [off-list ref] wrote:
Nguyen Thai Ngoc Duy [off-list ref] writes:quoted
Perhaps we should just reject this case. No sane body would ever use it.I'd have to say that dismissing before even trying is not a very disciplined attitude. Shouldn't an empty regexp simply match everything? Even on FBSD8, $ grep '' /etc/passwd seems to show everything. How hard would it be to do this in the codepath we are discussing?
To make '' match everything is easy. I'll cook up something when I get home. -- Duy